To: vim_dev@googlegroups.com Subject: Patch 8.2.3205 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 8.2.3205 Problem: Coverity reports a null pointer dereference. Solution: Change the logic to avoid Coverity gets confused. Files: src/vim9compile.c *** ../vim-8.2.3204/src/vim9compile.c 2021-07-22 19:11:05.336650367 +0200 --- src/vim9compile.c 2021-07-23 19:28:54.134646326 +0200 *************** *** 5175,5188 **** cctx->ctx_lnum = start_ctx_lnum; status = check_ppconst_bool(ppconst); ! if (status == OK) { // TODO: use ppconst if the value is a constant generate_ppconst(cctx, ppconst); // Every part must evaluate to a bool. ! status = (bool_on_stack(cctx)); ! if (status == OK) status = ga_grow(&end_ga, 1); } cctx->ctx_lnum = save_lnum; --- 5175,5188 ---- cctx->ctx_lnum = start_ctx_lnum; status = check_ppconst_bool(ppconst); ! if (status != FAIL) { // TODO: use ppconst if the value is a constant generate_ppconst(cctx, ppconst); // Every part must evaluate to a bool. ! status = bool_on_stack(cctx); ! if (status != FAIL) status = ga_grow(&end_ga, 1); } cctx->ctx_lnum = save_lnum; *** ../vim-8.2.3204/src/version.c 2021-07-22 21:32:38.429405726 +0200 --- src/version.c 2021-07-23 19:30:06.578439759 +0200 *************** *** 757,758 **** --- 757,760 ---- { /* Add new patch number below this line */ + /**/ + 3205, /**/ -- Don't be humble ... you're not that great. -- Golda Meir /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// \\\ \\\ sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///