To: vim_dev@googlegroups.com Subject: Patch 7.4.2083 Fcc: outbox From: Bram Moolenaar Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ------------ Patch 7.4.2083 Problem: Coverity complains about not restoring a value. Solution: Restore the value, although it's not really needed. Change return to jump to cleanup, might leak memory. Files: src/userfunc.c *** ../vim-7.4.2082/src/userfunc.c 2016-07-19 22:43:06.378767804 +0200 --- src/userfunc.c 2016-07-20 22:07:05.236032209 +0200 *************** *** 199,212 **** break; } if (newargs != NULL && ga_grow(newargs, 1) == FAIL) ! return FAIL; if (newargs != NULL) { c = *p; *p = NUL; arg = vim_strsave(arg); if (arg == NULL) goto err_ret; /* Check for duplicate argument name. */ for (i = 0; i < newargs->ga_len; ++i) --- 199,215 ---- break; } if (newargs != NULL && ga_grow(newargs, 1) == FAIL) ! goto err_ret; if (newargs != NULL) { c = *p; *p = NUL; arg = vim_strsave(arg); if (arg == NULL) + { + *p = c; goto err_ret; + } /* Check for duplicate argument name. */ for (i = 0; i < newargs->ga_len; ++i) *** ../vim-7.4.2082/src/version.c 2016-07-20 22:00:55.859928795 +0200 --- src/version.c 2016-07-20 22:08:19.111253774 +0200 *************** *** 760,761 **** --- 760,763 ---- { /* Add new patch number below this line */ + /**/ + 2083, /**/ -- ARTHUR: Bloody peasant! DENNIS: Oh, what a give away. Did you hear that, did you hear that, eh? That's what I'm on about -- did you see him repressing me, you saw it didn't you? The Quest for the Holy Grail (Monty Python) /// Bram Moolenaar -- Bram@Moolenaar.net -- http://www.Moolenaar.net \\\ /// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\ \\\ an exciting new programming language -- http://www.Zimbu.org /// \\\ help me help AIDS victims -- http://ICCF-Holland.org ///